-----Original Message----- From: Jasha Joachimsthal [mailto:[email protected]] Sent: Tuesday, November 01, 2011 10:10 AM To: [email protected] Subject: Re: [discuss] Apache Rave 0.5-incubating Release Candidate
On 1 November 2011 15:05, Ciancetta, Jesse E. <[email protected]> wrote: > >-----Original Message----- > >From: Jasha Joachimsthal [mailto:[email protected]] > >Sent: Tuesday, November 01, 2011 10:00 AM > >To: [email protected] > >Subject: Re: [discuss] Apache Rave 0.5-incubating Release Candidate > > > >On 1 November 2011 14:50, Marlon Pierce <[email protected]> wrote: > > > >> -----BEGIN PGP SIGNED MESSAGE----- > >> Hash: SHA1 > >> > >> I was able to download and run the svn tagged version, source release, > and > >> the .tar.gz and .zip demo artifacts correctly. However, there seems to > be > >> a bug if I try to add a new gadget with the same URL twice. That is, I > >> tried adding http://www.google.com/ig/modules/builtin_weather.xml with > >> two different names. The first time worked correctly (or at least is > >> waiting on admin approval). The second time produced an error ("Rave has > >> suffered a brief meltdown"). I won't put the stack trace here. > >> > > > >The widget URL is unique to prevent duplicates. Until recently the user > saw > >a message in the add widget form that the widget already exists in the > >database. We need to find out why the error page is shown now. > > > > I don't personally view this as a blocker though since it only happens in > a very specific case -- does anyone disagree? > > It's not nice and should be fixed, but I don't see it as a blocker either. > Jasha +1 on it needing to be fixed but not being a blocker. The error is occurring because: 1) DefaultWidgetService.registerNewWidget returns a null Widget if the url already exists, and 2) the RavePermissionEvaluator.hasPermission functions need to handle null objects better. I'll create a bug ticket for this issue. > >> > >> > >> Some other (probably non-blocking) issues: > >> > >> * We need an obvious way to get to the admin interface from the front > >page > >> or from the canonical user (or any other admin) account. > >> > > > >More than that: we need to work out how the menu should behave. Now we > >build up the menu per JSP with items that may or may not be there. > > > > > >> > >> * If I approve a widget (change "preview" to "publish"), the form action > >> should take me back to the widgets list or at least let me know if the > >> action was successful or not. > >> > > > >Sorry, I haven't added any feedback yet in the admin interface. If the > >action was successful, you are now redirected back to the form. > > > > > >> > >> * If I rate a widget, I can go to +2 or -2 rather than +1 or -1. > >> > > > >That's probably a display issue until you refresh the page. After the > vote, > >the number is updated client side until you refresh the page and you get > >the real value from the server. > > > > > >> > >> Marlon > >> -----BEGIN PGP SIGNATURE----- > >> Version: GnuPG/MacGPG2 v2.0.16 (Darwin) > >> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > >> > >> > >iQEcBAEBAgAGBQJOr/kkAAoJEEfVXEODPFID0q0H+wavhJTQB+ALUbOWvqM/ > >Fht5 > >> > >VVTWPd1iIMLcg0KkYQrhsGosDGKX3kpMzU8pC9LqT1wpqaajLIE+dO2BWSEnC > >54C > >> > >UM4o4t5XmBncUw8VcMqttl8O50tqp3bXhOLCQIf3s9TeGVYCC+sXcI8/9DzadN > >oz > >> > >7q9FPdysVd18yuD3jKx/TxeLIgSsFqSEXbk+A2UJkVAPJTgr+fOXALdoBByN92Cw > >> > >DNdm9el9kNF9iNLxS2MCCudUqQA2DLSaqa776Aj3awC4XUkSuut0p/uznHTRb > >D61 > >> > >/eno5igk20PyMrHH+S4ezdCo6esJGn+GwybLgo0mHPhSLFy9Xhu75oSDuJF2t/s > >= > >> =clBo > >> -----END PGP SIGNATURE----- > >> > --- Anthony Carlucci | SW App Dev Eng, Sr. | R501 / KW App Development & Maint e: [email protected] | v: 781.271.2432 | f: 781.271.3299 The MITRE Corporation | 202 Burlington Rd | Bedford, MA 01730-1420
