On 11/01/2011 03:59 PM, Jasha Joachimsthal wrote:
<snip/>
The widget URL is unique to prevent duplicates. Until recently the user
saw
a message in the add widget form that the widget already exists in the
database. We need to find out why the error page is shown now.
I don't personally view this as a blocker though since it only happens in
a very specific case -- does anyone disagree?
It's not nice and should be fixed, but I don't see it as a blocker
either.
Jasha
+1 on it needing to be fixed but not being a blocker.
The error is occurring because: 1) DefaultWidgetService.registerNewWidget
returns a null Widget if the url already exists, and 2) the
RavePermissionEvaluator.hasPermission functions need to handle null objects
better. I'll create a bug ticket for this issue.
I wrote the 1) logic but now I see it back I see room for improvement. The
Validator can reject the new widget if its url is already present. Then if
for some reason DefaultWidgetService#registerNewWidget is called for a URL
that already exists, it can throw a (DuplicateItem)Exception instead of
returning null. WDYT?
Jasha
+1 on the fix and +1 on regarding this as a non-blocker, so fine to fix for next
release.
I haven't yet reviewed the release itself, so this is not a vote for the
release, just concerns this issue.
