-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Also, you may want to increase the test coverage to include the new code.
Marlon On 12/8/11 11:44 AM, Marlon Pierce wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3078/#review3741 > ----------------------------------------------------------- > > > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties > <https://reviews.apache.org/r/3078/#comment8431> > > The patch for this part fails for me for some reason, so I had to make > updates manually. Also (a quibble) these are not in alphabetical order. > > > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp > <https://reviews.apache.org/r/3078/#comment8432> > > The message gets URL encoded--spaces become %. > > Also the message doesn't clearly state that the gadget is disabled, which > it should. > > > - Marlon > > > On 2011-12-08 15:33:12, Venkat Mahadevan wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/3078/ >> ----------------------------------------------------------- >> >> (Updated 2011-12-08 15:33:12) >> >> >> Review request for rave. >> >> >> Summary >> ------- >> >> RAVE-210 Administrators should be able to disable widgets >> >> To disable a gadget, login as Admin and go to "Admin Interface" and to the >> Widgets tab and click on a widget to get its metadata. Here you will find >> two new columns, "Disable Gadget" and "Disable Gadget Message". One can >> disable the gadget from rendering if you check he disable gadget checkbox >> and whatever you put in the message will be displayed on the gadget when the >> gadget is rendered. If you want to enable it, uncheck the checkbox. The >> gadget will be displayed as usual (even if the disable message is still >> there in the metadata, since the checkbox overrides it). >> >> >> Diffs >> ----- >> >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java >> 1211897 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/AbstractContextAwareSingletonBeanDependentTag.java >> 1211897 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java >> 1211897 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties >> 1211897 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp >> 1211897 >> >> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave.js >> 1211897 >> >> Diff: https://reviews.apache.org/r/3078/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Venkat >> >> > > -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO4PSgAAoJEEfVXEODPFIDg4cH/iVx9Tx3EWkZy1AlJUB1XKW1 v4OjYUsrAiQQxwNyYTBfw3MpEH3Yda57OqCssXGJIfzACMaNfDiWOkmk1g+1UGDy p7xksB9nwwPpPbjqQphlGQSdI71sVGurVtAkh3hKEaDkkwq4mmeeq1tixUoO3YzD s+35BE/TxJtAeqvvwFEMRwVs2uq2b88/LKBnupsv1eZYPI8ac00Ijy9mvohKOX2x Z8m6aXb8JppWBQjZ96NjGM3Igz1p9ZADdePq0R/blKIfzirciV23I4pKcK/mWBLE jIS/+lK9LxsEOawDqc7dNEpt3TBDC//YkGUSnu9pMb13QzeC4ZkHjUl3aC8029I= =Oeu9 -----END PGP SIGNATURE-----
