Marlon Regarding the message stating the disabled state, I will add it to the gadget title so we will see something like ' NYTimes.com - Top Stories - DISABLED'
Also since we can enter any message, one can enter the specific message stating that the gadget has been disabled due to some reason. Something like, 'The gadget is disabled due to licensing issues' or something like that. -Venkat -----Original Message----- From: Marlon Pierce [mailto:[email protected]] Sent: Thursday, December 08, 2011 11:45 AM To: Mahadevan, Venkat; Marlon Pierce; rave Subject: Re: Review Request: RAVE-210 Administrators should be able to disable widgets ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3078/#review3741 ----------------------------------------------------------- https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties <https://reviews.apache.org/r/3078/#comment8431> The patch for this part fails for me for some reason, so I had to make updates manually. Also (a quibble) these are not in alphabetical order. https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp <https://reviews.apache.org/r/3078/#comment8432> The message gets URL encoded--spaces become %. Also the message doesn't clearly state that the gadget is disabled, which it should. - Marlon On 2011-12-08 15:33:12, Venkat Mahadevan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3078/ > ----------------------------------------------------------- > > (Updated 2011-12-08 15:33:12) > > > Review request for rave. > > > Summary > ------- > > RAVE-210 Administrators should be able to disable widgets > > To disable a gadget, login as Admin and go to "Admin Interface" and to the > Widgets tab and click on a widget to get its metadata. Here you will find two > new columns, "Disable Gadget" and "Disable Gadget Message". One can disable > the gadget from rendering if you check he disable gadget checkbox and > whatever you put in the message will be displayed on the gadget when the > gadget is rendered. If you want to enable it, uncheck the checkbox. The > gadget will be displayed as usual (even if the disable message is still there > in the metadata, since the checkbox overrides it). > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java > 1211897 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/AbstractContextAwareSingletonBeanDependentTag.java > 1211897 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java > 1211897 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties > 1211897 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp > 1211897 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave.js > 1211897 > > Diff: https://reviews.apache.org/r/3078/diff > > > Testing > ------- > > > Thanks, > > Venkat > >
