----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3300/#review4144 -----------------------------------------------------------
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js <https://reviews.apache.org/r/3300/#comment9356> Probably better to use jquery here and below instead of document.getElementById for portability. trunk/rave-portal-resources/src/main/webapp/script/rave_api.js <https://reviews.apache.org/r/3300/#comment9357> Same here: I'd suggest uniformly using jquery html() over innerHTML. I'm assuming this will work more consistently across browsers. trunk/rave-portal-resources/src/main/webapp/script/rave_api.js <https://reviews.apache.org/r/3300/#comment9358> Probably better to explicitly check for isLike==false here with an else if and then use a final else to catch error conditions. trunk/rave-portal-resources/src/main/webapp/script/rave_api.js <https://reviews.apache.org/r/3300/#comment9359> I don't understand why you are using 10 as a magic number here. trunk/rave-portal-resources/src/main/webapp/script/rave_api.js <https://reviews.apache.org/r/3300/#comment9360> I recommend using jquery features instead of document.getElementById, innerHTML, etc. - Marlon On 2011-12-23 22:26:48, Ankur Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3300/ > ----------------------------------------------------------- > > (Updated 2011-12-23 22:26:48) > > > Review request for rave and Marlon Pierce. > > > Summary > ------- > > Made the following changes:- > -> Like, dislike and total votes displayed separately > -> Changed the "change" function to "click" function to remove the double > click bug (Rave-359) > -> Created a common handler function to update the widget ratings shown on > the page called through click functions > > Files modified:- > - messages.properties > - rave_api.js > - rave_store.js > - store.jsp > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1222860 > trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1222860 > trunk/rave-portal-resources/src/main/resources/messages.properties 1222860 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp > 1222860 > > Diff: https://reviews.apache.org/r/3300/diff > > > Testing > ------- > > > Thanks, > > Ankur > >
