----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3300/#review4146 -----------------------------------------------------------
The code worked fine for me, although the patch didn't. I had to manually update rave_api.js and messages.properties. I think it needs a few minor updates before publishing--see previous and inline comments. - Marlon On 2011-12-23 22:26:48, Ankur Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3300/ > ----------------------------------------------------------- > > (Updated 2011-12-23 22:26:48) > > > Review request for rave and Marlon Pierce. > > > Summary > ------- > > Made the following changes:- > -> Like, dislike and total votes displayed separately > -> Changed the "change" function to "click" function to remove the double > click bug (Rave-359) > -> Created a common handler function to update the widget ratings shown on > the page called through click functions > > Files modified:- > - messages.properties > - rave_api.js > - rave_store.js > - store.jsp > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1222860 > trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1222860 > trunk/rave-portal-resources/src/main/resources/messages.properties 1222860 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp > 1222860 > > Diff: https://reviews.apache.org/r/3300/diff > > > Testing > ------- > > > Thanks, > > Ankur > >
