----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3380/#review4187 -----------------------------------------------------------
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/pom.xml <https://reviews.apache.org/r/3380/#comment9436> Do you know the licensing situation with this jar? This will need to added to the NOTICE files (./rave-portal/src/main/dist/NOTICE) assuming it is Apache V2 compatible. https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/resources/portal.properties <https://reviews.apache.org/r/3380/#comment9437> Should be placed earlier for alphabetical ordering. https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/portal.properties <https://reviews.apache.org/r/3380/#comment9438> I'm not sure what to put here to enable this. Also, the error messages displayed on the new account page if you don't have portal.captcha.key.public and .private set correctly are too small and unobtrusive. https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp <https://reviews.apache.org/r/3380/#comment9439> I assume this outputs the error message for misconfigured properties. If so, the error messages are easily missed. Need to have an appropriate styling. - Marlon On 2012-01-04 16:08:40, marijan milicevic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3380/ > ----------------------------------------------------------- > > (Updated 2012-01-04 16:08:40) > > > Review request for rave. > > > Summary > ------- > > ReCaptcha implementation > > > Diffs > ----- > > https://svn.apache.org/repos/asf/incubator/rave/trunk/pom.xml 1227203 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/pom.xml > 1227203 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/CaptchaService.java > PRE-CREATION > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/ReCaptchaService.java > PRE-CREATION > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/resources/portal.properties > 1227203 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/NewAccountController.java > 1227203 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/NewAccountControllerTest.java > 1227203 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/portal.properties > 1227203 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp > 1227203 > > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/test/resources/portal.properties > 1227203 > > Diff: https://reviews.apache.org/r/3380/diff > > > Testing > ------- > > > Thanks, > > marijan > >
