> On 2012-01-05 12:14:29, Jasha Joachimsthal wrote:
> > Thanks Marijan for the patch.
> > If you enter no or an incorrect CAPTCHA value (some are hard to read), only
> > the username is filled in after submitting the form. It would be better if
> > email address and layout are remembered as well.
>
> marijan milicevic wrote:
> Hi Jasha,
> I've changed email binding in newaccount.jsp so email is remembered and
> layout was selected for me, so, no changes there
I now see why it didn't work before. The spring:bind was there but the <input
type="email" /> didn't have a value="${status.value}" attribute.
- Jasha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3380/#review4201
-----------------------------------------------------------
On 2012-01-05 17:13:44, marijan milicevic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3380/
> -----------------------------------------------------------
>
> (Updated 2012-01-05 17:13:44)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> ReCaptcha implementation
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/pom.xml 1227566
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/pom.xml
> 1227566
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/CaptchaService.java
> PRE-CREATION
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/ReCaptchaService.java
> PRE-CREATION
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/resources/portal.properties
> 1227566
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/NewAccountController.java
> 1227566
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/NewAccountControllerTest.java
> 1227566
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/portal.properties
> 1227566
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp
> 1227566
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/test/resources/portal.properties
> 1227566
>
> Diff: https://reviews.apache.org/r/3380/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> marijan
>
>
