-1 we don't review code by committers either before it is committed. It should be left to the committer who applies the patch if that patch meets the standards of the project. It can't harm to give other committers some time to respond to a patch but I wouldn't make a hard rule to need at least 2 reviews.
On 5 January 2012 15:38, Marlon Pierce <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi all-- > > I suggest as a guideline that two reviewers (or more) should review each > patch submitted to reviews.apache.org before the patch is committed. Are > you +1 or -1 for this? > > > Marlon > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG/MacGPG2 v2.0.16 (Darwin) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iQEcBAEBAgAGBQJPBbXtAAoJEEfVXEODPFIDzN0H/2v+v47KvkbGUBOrcElTDWxF > 7CKlcomvlUaIY/wxpjfI4QkPpcqvCis/uEFulOgo9sWSD1IFd4EzdoXU+VplnHCL > ehoY3vhfqZLQW5nUOoSbB6aL6ll41Mw65N+h/Zm2kvz3fMvR+faqq8Bee1Jhkc8z > 48HXskZojs4WZBgdanovjESMImBsphBeGkdZpCFLH56koiwWKB3Cef9DLEkhtTuq > hhVULC2Z+3MvXsxC+01Y548YSna8CmCZtYU9dOfuA8bnYcjtiFE2qgoxFUPu5aux > rLIQR4ZrOdsocAPTjZ5slGEq183yPeEo1N270FRKOYEdPFJeoBsH8bxc1sa8sFY= > =M6QS > -----END PGP SIGNATURE----- >
