> On 2012-01-11 22:02:56, Marlon Pierce wrote: > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp, > > line 31 > > <https://reviews.apache.org/r/3462/diff/1/?file=68146#file68146line31> > > > > This won't work for new accounts, which don't have display names. Use > > username instead or else we need to change the new account forms.
I can keep a check on that, like if display name is not provided then use the user name. Similar to what is done in page.jsp header. > On 2012-01-11 22:02:56, Marlon Pierce wrote: > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp, > > line 23 > > <https://reviews.apache.org/r/3462/diff/1/?file=68147#file68147line23> > > > > What is body content supposed to be? It can be things like, by default it can show the search button for the user to search friends and if he wants to edit his profile information such as basic information, we can have a link or a button on that tab (menu) which will refresh the body content and make the editor for basic information visible. But for now I kept it empty as these features are for other tickets. > On 2012-01-11 22:02:56, Marlon Pierce wrote: > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp, > > line 46 > > <https://reviews.apache.org/r/3462/diff/1/?file=68150#file68150line46> > > > > Users should be able to update this information. Shouldn't this be set as a new sub task? - Ankur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3462/#review4318 ----------------------------------------------------------- On 2012-01-11 20:26:03, Ankur Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3462/ > ----------------------------------------------------------- > > (Updated 2012-01-11 20:26:03) > > > Review request for rave and Marlon Pierce. > > > Summary > ------- > > Addressed the following issues:- > -> added test class for UserInfoController > -> added links for home, admin interface and store > -> added Dutch Translations to messages_nl.properties > > Yes, I am assuming status to be single/married for now. > > > Diffs > ----- > > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserInfoController.java > PRE-CREATION > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java > 1230199 > > trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/UserInfoControllerTest.java > PRE-CREATION > trunk/rave-portal-resources/src/main/resources/messages.properties 1230199 > trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1230199 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp > 1230199 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_footer.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/user_profile.jsp > PRE-CREATION > trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1230199 > trunk/rave-portal-resources/src/main/webapp/css/default.css 1230199 > trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1230199 > trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/3462/diff > > > Testing > ------- > > > Thanks, > > Ankur > >
