----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3462/#review4359 -----------------------------------------------------------
Oops -- I didn't realize that this review request was a follow up to a previously posted review request -- I just added comments on the previous review request here: https://reviews.apache.org/r/3449/ although I think those comments still apply. You should be able to respond to feedback and post subsequent patches without needing to create an entirely new review -- let us know if you have trouble finding the right places to do that and we can help out. - Jesse On 2012-01-11 20:26:03, Ankur Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3462/ > ----------------------------------------------------------- > > (Updated 2012-01-11 20:26:03) > > > Review request for rave and Marlon Pierce. > > > Summary > ------- > > Addressed the following issues:- > -> added test class for UserInfoController > -> added links for home, admin interface and store > -> added Dutch Translations to messages_nl.properties > > Yes, I am assuming status to be single/married for now. > > > Diffs > ----- > > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserInfoController.java > PRE-CREATION > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java > 1230199 > > trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/UserInfoControllerTest.java > PRE-CREATION > trunk/rave-portal-resources/src/main/resources/messages.properties 1230199 > trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1230199 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp > 1230199 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_footer.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/user_profile.jsp > PRE-CREATION > trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1230199 > trunk/rave-portal-resources/src/main/webapp/css/default.css 1230199 > trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1230199 > trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/3462/diff > > > Testing > ------- > > > Thanks, > > Ankur > >
