> On 2012-01-26 21:48:31, Anthony Carlucci wrote: > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/category.jsp, > > line 56 > > <https://reviews.apache.org/r/3641/diff/1/?file=70854#file70854line56> > > > > Use a message bundle item here for the value instead of hard-coded text
For internationalization also. - Marlon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3641/#review4632 ----------------------------------------------------------- On 2012-01-26 18:17:21, Aaron Gooch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3641/ > ----------------------------------------------------------- > > (Updated 2012-01-26 18:17:21) > > > Review request for rave. > > > Summary > ------- > > Rave-433 implementation of controller and jsps > > > Diffs > ----- > > > trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/CategoryService.java > 1236296 > > trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultCategoryService.java > 1236296 > > trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultCategoryServiceTest.java > 1236296 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/AdminControllerUtil.java > 1236296 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/CategoryController.java > PRE-CREATION > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java > 1236296 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java > 1236296 > > trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/CategoryControllerTest.java > PRE-CREATION > trunk/rave-portal-resources/src/main/resources/messages.properties 1236296 > trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1236296 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/category.jsp > PRE-CREATION > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/categoryDetail.jsp > PRE-CREATION > > Diff: https://reviews.apache.org/r/3641/diff > > > Testing > ------- > > > Thanks, > > Aaron > >
