----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3641/ -----------------------------------------------------------
(Updated 2012-01-27 16:22:13.487352) Review request for rave. Changes ------- Updated to include Tony's review findings and also added to international (Dutch) message bundle per Marlon. fixed naming convention in ViewNames updated Controller and tests to reflect new naming convention category.jsp is now categories.jsp added apache license to test updated categories.jsp and categoryDetail.jsp to use message bundle on the button clicks. Summary ------- Rave-433 implementation of controller and jsps Diffs (updated) ----- trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/CategoryService.java 1236692 trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultCategoryService.java 1236692 trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultCategoryServiceTest.java 1236692 trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/AdminControllerUtil.java 1236692 trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/CategoryController.java PRE-CREATION trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1236721 trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1236721 trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/CategoryControllerTest.java PRE-CREATION trunk/rave-portal-resources/src/main/resources/messages.properties 1236692 trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1236692 trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/categories.jsp PRE-CREATION trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/categoryDetail.jsp PRE-CREATION Diff: https://reviews.apache.org/r/3641/diff Testing ------- Thanks, Aaron
