----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3896/#review5121 -----------------------------------------------------------
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java <https://reviews.apache.org/r/3896/#comment11220> small nit, but are you really setting up a form or are you rendering a profile? trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java <https://reviews.apache.org/r/3896/#comment11221> Why not use addAttributesToModel helper? trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp <https://reviews.apache.org/r/3896/#comment11222> Why do we have to similar tests that output the same result? - mfranklin On 2012-02-14 20:41:20, hilker.j wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3896/ > ----------------------------------------------------------- > > (Updated 2012-02-14 20:41:20) > > > Review request for rave. > > > Summary > ------- > > Controller for the person profile > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/resources/messages.properties 1244037 > trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1244037 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp > 1244037 > > trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java > 1244037 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java > 1244037 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java > 1244037 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp > PRE-CREATION > > Diff: https://reviews.apache.org/r/3896/diff > > > Testing > ------- > > > Thanks, > > hilker.j > >
