> On 2012-02-15 13:30:49, mfranklin wrote: > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java, > > line 73 > > <https://reviews.apache.org/r/3896/diff/2/?file=74931#file74931line73> > > > > Why not use addAttributesToModel helper? > > hilker.j wrote: > The helper additionally contains the referring_page_id. I felt for > querying people, the entry point would either be manually modifying the URL, > a link, or a search. In some of these cases you would not have a referring > page id to pass, and not including a referring page id appears to 404 the > page in the current set up. Perhaps we need to look into a new way to handle > saving the tab a person was using while entering menus (The current > phonebook does it well)
I think we should either re-examine the current approach for tracking a users visited page or make it so this method follows the current convention. If you want to make it an optional parameter use @RequestParameter(optional=true) - mfranklin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3896/#review5121 ----------------------------------------------------------- On 2012-02-14 20:41:20, hilker.j wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3896/ > ----------------------------------------------------------- > > (Updated 2012-02-14 20:41:20) > > > Review request for rave. > > > Summary > ------- > > Controller for the person profile > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/resources/messages.properties 1244037 > trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1244037 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp > 1244037 > > trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java > 1244037 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java > 1244037 > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java > 1244037 > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp > PRE-CREATION > > Diff: https://reviews.apache.org/r/3896/diff > > > Testing > ------- > > > Thanks, > > hilker.j > >
