On 3/21/12 6:03 PM, "Ate Douma" <[email protected]> wrote:
>On 03/21/2012 10:07 PM, Franklin, Matthew B. wrote: >> -----Original Message----- >>> From: Ate Douma [mailto:[email protected]] >>> Sent: Thursday, March 08, 2012 11:32 AM >>> To: [email protected] >>> Subject: Re: [PROPOSAL] - Rave-Shindig Reorganization >>> >>> On 03/08/2012 05:23 PM, Franklin, Matthew B. wrote: >>>> >>>> >>>>> -----Original Message----- >>>>> From: Mahadevan, Venkat [mailto:[email protected]] >>>>> Sent: Thursday, March 08, 2012 10:58 AM >>>>> To: [email protected] >>>>> Subject: [PROPOSAL] - Rave-Shindig Reorganization >>>>> >>>>> Hi All >>>>> >>>>> We are working on a project internally that uses the Rave code base. >>>>> Currently we overlay rave-shindig and override the >>>>>rave.shindig.properties >>>>> file. Going forward we would like to implement the interfaces in >>>>>rave- >>> shindig >>>>> for some of the features like findFriends, findAllConnectedPeople >>>>>etc. The >>>>> current overlay structure is hindering us from implementing these >>> features. >>>>> So I would to put forward this proposal for refactoring the current >>>>>rave- >>>>> shindig and rave-providers structures which would allow anyone to >>>>> implement the shindig changes. >>>>> >>>>> The new structure would look like this: >>>>> >>>>> ... >>>>> rave-portal-dependencies >>>>> ... >>>>> rave-providers >>>>> rave-opensocial-provider >>>>> rave-opensocial-core >>>>> rave-opensocial-client >>>>> rave-opensocial-server >>>>> rave-shindig-resources >>>>> rave-shindig-dependencies >>>>> rave-shindig >>>>> >>>>> Any thoughts, suggestions? >>>> >>>> Are these all at the same level? If not, can you show how the >>>>structure >>> would be? >>>> >>>> IE) |_directory >>>> |_ subdirectory >>>> >>> >>> Did you take into account the incoming changes of SHINDIG-1691 for the >>>next >>> shindig 2.5.0 release? Those should make customizing and extending >>>Shindig >>> much >>> easier. >> >> While we wait for the patch to be applied and a release to be cut, can >>we start the re-organization? I propose the following intermediate >>structure tweaked from Venkat's proposal: >> >> rave-portal-dependencies >> |__rave-opensocial-provider >> |__rave-opensocial-core >> |__rave-opensocial-client >> |__rave-opensocial-server* >> |_ rave-shindig >> >> * Once the patch is applied and there is a new release, we can add >>rave-shinidg-resources& rave-shindig-dependencies as submodules of this >>module. >> >> Assuming lazy consensus, I will make this change tomorrow >>afternoon/evening. > >To be honest, the above isn't clear to me: does it represent a folder >hierarchy >and/or module dependency tree? Was meant to be a folder hierarchy and module tree >For either case, I can't comprehend the depicted relations though. >IMO portal-dependencies and rave-shindig concerns two different apps, so >they >shouldn't end up in one graph (either way). That is the cold medicine typing, s/rave-portal-dependencies/rave-providers > >At any rate, if you already have a tested/working re-organization >locally, I'm >fine with lazy consensus. It should become clear to me when I see it :) > >Ate > >> >>> >>>> >>>>> >>>>> >>>>> Thanks >>>>> Venkat >>>> >> >
