[
https://issues.apache.org/jira/browse/RAVE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236700#comment-13236700
]
[email protected] commented on RAVE-526:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4468/
-----------------------------------------------------------
Review request for rave.
Summary
-------
An optional attribute for the ModulePrefs element in a gadget definition is
'height', which states the static or default height of a gadget. Rave currently
has a default height of 250px, which is added to the iframe element in which a
gadget is created. It does not check if a height attribute is set on the gadget
to render.
Because iGoogle supports the height attribute and a lot of available gadgets
set their height statically, it would be a nice feature for Rave to support the
height attribute as well.
This addresses bug RAVE-526.
https://issues.apache.org/jira/browse/RAVE-526
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1295528
Diff: https://reviews.apache.org/r/4468/diff
Testing
-------
Tested on gadgets:
- without height attribute and without dynamic height,
- without height and with dynamic height,
- with height and without dynamic height,
- with height and with dynamic height
Thanks,
Dennis
> Support height attribute of open social gadget definition
> ---------------------------------------------------------
>
> Key: RAVE-526
> URL: https://issues.apache.org/jira/browse/RAVE-526
> Project: Rave
> Issue Type: Bug
> Components: rave-portal
> Affects Versions: 0.10-INCUBATING
> Environment: All platforms
> Reporter: Dennis van der Laan
> Priority: Minor
> Labels: features, javascript
>
> An optional attribute for the ModulePrefs element in a gadget definition is
> 'height', which states the static or default height of a gadget. Rave
> currently has a default height of 250px, which is added to the iframe element
> in which a gadget is created. It does not check if a height attribute is set
> on the gadget to render.
> Because iGoogle supports the height attribute and a lot of available gadgets
> set their height statically, it would be a nice feature for Rave to support
> the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
