[
https://issues.apache.org/jira/browse/RAVE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236712#comment-13236712
]
[email protected] commented on RAVE-526:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4468/#review6284
-----------------------------------------------------------
trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js
<https://reviews.apache.org/r/4468/#comment13627>
Why not move this logic into getSizeFromElement and rename the function
calculateSize ?
trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js
<https://reviews.apache.org/r/4468/#comment13628>
if you don't mind, set width to size.width and just replace
elem.clientWidth - OFFSET with "100%" in the function.
I know this one isn't your doing but, nothing wrong with fixing it while
you are there :)
- mfranklin
On 2012-03-23 15:55:22, Dennis Laan, van der wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4468/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 15:55:22)
bq.
bq.
bq. Review request for rave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. An optional attribute for the ModulePrefs element in a gadget definition
is 'height', which states the static or default height of a gadget. Rave
currently has a default height of 250px, which is added to the iframe element
in which a gadget is created. It does not check if a height attribute is set on
the gadget to render.
bq. Because iGoogle supports the height attribute and a lot of available
gadgets set their height statically, it would be a nice feature for Rave to
support the height attribute as well.
bq.
bq.
bq. This addresses bug RAVE-526.
bq. https://issues.apache.org/jira/browse/RAVE-526
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js
1295528
bq.
bq. Diff: https://reviews.apache.org/r/4468/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested on gadgets:
bq. - without height attribute and without dynamic height,
bq. - without height and with dynamic height,
bq. - with height and without dynamic height,
bq. - with height and with dynamic height
bq.
bq.
bq. Thanks,
bq.
bq. Dennis
bq.
bq.
> Support height attribute of open social gadget definition
> ---------------------------------------------------------
>
> Key: RAVE-526
> URL: https://issues.apache.org/jira/browse/RAVE-526
> Project: Rave
> Issue Type: Bug
> Components: rave-portal
> Affects Versions: 0.10-INCUBATING
> Environment: All platforms
> Reporter: Dennis van der Laan
> Priority: Minor
> Labels: features, javascript
>
> An optional attribute for the ModulePrefs element in a gadget definition is
> 'height', which states the static or default height of a gadget. Rave
> currently has a default height of 250px, which is added to the iframe element
> in which a gadget is created. It does not check if a height attribute is set
> on the gadget to render.
> Because iGoogle supports the height attribute and a lot of available gadgets
> set their height statically, it would be a nice feature for Rave to support
> the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
