Okay. Changes are done and appear to work for *just* my test case. Of course I'd like to ensure I didn't break anything along the way.
I'd like to run the unit test suite on them before creating a PR, but am unsure on what steps to take. Given my local cloned git repo, with my edits to Subsetter.h, what's the right way to recompile against it and run the unit tests there? Many thanks, Will On Thu, Nov 8, 2018 at 2:45 PM, William Nolan <w...@landale.net> wrote: > Thanks, guys. > > I submitted issue #919 <https://github.com/RcppCore/Rcpp/issues/919> with > a small-ish test case showing the issue. > > Will take a look at what's necessary to address. I see subsetting is in > the unit tests, but this is a funny one in that verifying the fix works > there would require a big chunk of memory (16GB, i.e. 2^31 * 8 bytes for a > Numeric) to be present on the tester's machine -- seems excessive. > > Maybe it's enough for the fix to pass the existing unit tests, and pass > the testbed I put in the github issue. Anyway, TBD > > On Thu, Nov 8, 2018 at 11:30 AM, Dirk Eddelbuettel <e...@debian.org> wrote: > >> >> On 8 November 2018 at 09:19, William Nolan wrote: >> | Thanks. Will put together a small working example and file it. I might >> even attempt a fix in my copious free time ;-). >> >> Awesome :) >> >> We'll help. Small steps and iterations work well. >> >> Dirk >> >> -- >> http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org >> > >
_______________________________________________ Rcpp-devel mailing list Rcpp-devel@lists.r-forge.r-project.org https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/rcpp-devel
