Thanks. That did the trick. After testing w/my own test harness, I made sure the unit tests work with a baseline cloned fork. Then integrated my changes into the fork, re-built/checked with bumped-up version # and tests all passed again. Pushed fork to github.
I have just created PR #920 <https://github.com/RcppCore/Rcpp/pull/920>. Thanks for all the help, and hopefully I didn't mess it up too badly on the first try :-). Regards, Will On Thu, Nov 8, 2018 at 9:35 PM, Dirk Eddelbuettel <e...@debian.org> wrote: > > On 7 November 2018 at 23:28, Qiang Kou wrote: > | Hi, William, > | > | I think you can send the PR first. It will trigger the unit tests on > github. > > And running 'R CMD build ...' followed by 'R CMD check ...' on your > modified > sources tests them locally. There are equivalent GUI buttons in RStudio > you > can use and devtools has support too (that I am not familiar with). > > Dirk > > -- > http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org >
_______________________________________________ Rcpp-devel mailing list Rcpp-devel@lists.r-forge.r-project.org https://lists.r-forge.r-project.org/cgi-bin/mailman/listinfo/rcpp-devel
