Hello Eric, I was on vacation the last two weeks and that explains why I did not take a look at your Merge Request.
Your work on rdiff-backup is greatly appreciated and I usually take time to review the PR, but I have the feeling you are moving a bit too fast for the rest of the developers. Talking for me here, I can't keep up with your changes. During the "free" time I have for rdiff-backup, I am reviewing your changes instead of fixing bugs. I barely have a couple of hours per week to work on the project and I can't afford to review the PR in a timely manner all the time. I understand it can be frustrating for you and I am open to suggestions. For the time being, I will continue reviewing the PR when I have a chance. On Thu, Aug 6, 2020 at 1:47 AM Eric L. Zolf <ewl+rdiffbac...@lavar.de> wrote: > Hi, > > as the subject says, pull requests can stay for days without review, and > I really don't like merging my own PRs without someone having looked > over it. > > Reviewing documentation doesn't require any specific knowledge even if > being a native English speaker might be an advantage :-) Just tell the > author if you understand what he wrote, and if the language is correct. > > Reviewing code is more engaged but requires IMHO only some Python coding > knowledge and the ability to detect bad coding style, and challenge the > author to make sure nothing has been overlooked and everything is > properly commented. It doesn't require deep knowledge of the code but > can be a great way to gain this knowledge. > > You only need to review the PR which are _not_ WIP and where the > pipeline job was successful (green tick). > > Thanks, Eric > > -- IKUS Software inc. https://www.ikus-soft.com/ 514-971-6442 130 rue Doris St-Colomban, QC J5K 1T9
