On Fri, Apr 13, 2012 at 9:03 PM, Gianluca Sforna <gia...@gmail.com> wrote: > > Apparently, the tarball filename grew a ".src" suffix. If this new > naming scheme is going to stick I can adapt the package, otherwise I'd > suggest removing that part so it's easier to predict (and check for) > new releases file names with automated tools.
It was a mistake on my part. I've fixed it in both the sourceforge and google code download areas. > I started a package review to include rdkit in Fedora (and possibily, > EPEL) repositories here: > https://bugzilla.redhat.com/show_bug.cgi?id=804125 > > The review reaised a couple issues I think we can fix in rdkit: > > * there are a couple header files with executable permissions, would > be nice to have it removed: > - Code/RDBoost/python_streambuf.h > - Code/GraphMol/Wrap/ForwardSDMolSupplier.cpp this is now fixed in svn. Do you want me to redo the source release so that the permissions are fixed in the tarball, or are you ok knowing that it's fixed? > * I believe it was raised at some time, but it's still there: somehow > there are a couple of exit() calls in the resulting librares. Of > course, a library calling exit is not really what you want :) so I > guess it would be also nice to get this investigated and fixed. > Here is the rpmlint output: > rdkit.x86_64: W: shared-lib-calls-exit > /usr/lib64/libSmilesParse.so.1.2012.03.1 exit@GLIBC_2.2.5 > rdkit.x86_64: W: shared-lib-calls-exit > /usr/lib64/libSLNParse.so.1.2012.03.1 exit@GLIBC_2.2.5 yeah, this came up early last year. Unfortunately we didn't find a solution then either. The exit() calls are inserted by flex: http://www.mail-archive.com/rdkit-discuss@lists.sourceforge.net/msg01471.html There is a flex bug report about this for flex (from 2008!): https://sourceforge.net/tracker/index.php?func=detail&aid=2125513&group_id=97492&atid=618177 There they claim that it was fixed in March of this year, so it should be cleared up with the next release of flex. Anything else that I can do to help you finish the review? -greg ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Rdkit-discuss mailing list Rdkit-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rdkit-discuss
