Alan Manuel Gloria: > fix done (attached bundle), I used a different tag variable instead of > re-using group.
Awesome. Applied. I also added a test case to check for this, so we don't regress. Feel free to add more test cases! BTW, I plan to remove the "CHANGES" section - git can track that just fine, no need to duplicate it. > Some code issues: > > 1. The group variable isn't used. At all. Looking at SRFI-49, it > looks like it is not used even in the reference implementation. > > 2. I think the existence of the clean function is an abomination. :-). I started with SFRI-49's reference implementation under the theory that it does what is needed. We may need to re-implement part/most/all of it - in the long run, it's important that it be "obviously right". But I don't think it's wasted time to work on it; if we re-implement parts, it's still helpful to have a starting point, and this gives a tool that we can use right now. --- David A. Wheeler ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Readable-discuss mailing list Readable-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/readable-discuss
