On Sun, Jul 15, 2012 at 7:11 PM, David A. Wheeler <dwhee...@dwheeler.com> wrote:
>> Yet another bundle!
>
> Awesome. Accepted.
>
> I really am reviewing every commit. I really appreciate the nicely focused
> changes in each commit, you've made them quite easy to review.
>
>> commit a9c142b5377dd1537508556da31d9a21c2ac02c4
>> Author: Alan Manuel K. Gloria <almkg...@gmail.com>
>> Date: Sun Jul 15 15:17:44 2012 +0800
>>
>> Added another example: list-of macro (list comprehension macro)
>
> Fair enough. I notice you're using SPLIT so you can use ... even if period
> is an indentation mark. That works, but it also makes me think that period
> should only be indentation if it's followed by space or tab.
>
> Your "define-module" looks like this:
> define-module
> . example list-of
> . :export
> . \
> . ; in Guile 1.6, module macros need to export the
> . ; functions they use.
> . list-of::concat-map
> . :export-syntax
> . \
> . list-of
>
> I believe you could do this instead (assuming SPLIT):
> define-module
> . example list-of
> . :export \ (list-of::concat-map)
> . :export-syntax \ (list-of)
Actually, I feel the former is superior, as it makes it significantly
much easier to add and remove individual items in the export lists.
In fact, I think I'll do the :export\n\t\\\n\t\t in production code,
which will probably be exporting a lot more (and will probably be
changing their interfaces quite a bit more)
>
>> commit 80da4a477e531e6995f4e06b84aade2efac419a4
>> Author: Alan Manuel K. Gloria <almkg...@gmail.com>
>> Date: Sun Jul 15 07:14:52 2012 +0800
>>
>> modern.scm: Have skip-whitespace handle comments, instead of the
>> individual reader's loops.
>>
>> This fixes the following bug:
>>
>> (;comment
>> )
>> ==>
>> (#{}#)
>>
>> (the #{}# is Guile's representation of a symbol without any
>> characters)
>
> Thanks! That solution looks reasonable, and it changes the test from fail to
> pass. I believe this is yet another bug we inherited from the sample SRFI 49
> implementation.
I doubt it, since this bug occurs in the modern-expressions
implementation and the only thing we got from SRFI 49 is
i-expressions.
Sincerely,
AmkG
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Readable-discuss mailing list
Readable-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/readable-discuss
