On Thursday, July 12, 2001 06:09:55 PM +0200 Stefan Fleiter <[EMAIL PROTECTED]>
wrote:
> Hi Dirk!
>
> On Thu, 12 Jul 2001 Dirk Mueller wrote:
>
>>> --- dir.c~ Wed Jul 4 14:52:37 2001
>>> +++ dir.c Wed Jul 4 14:53:43 2001
>
> [..]
>
>> This chunk is still missing in 2.4.7-pre6. Is it possible to submit this to
>> Linus ?
>
> You are perfectly right and for me it shows that there are some problems
> regarding organisation, leadership and responsibilities in the Reiser team.
>
> Dangerous new patches are something else, but this is a bug fix and should
> therefore have been submitted at once.
Bug fixes need testing, regardless of how correct they look.
This got sent to linus and alan today:
diff -Nru a/fs/reiserfs/dir.c b/fs/reiserfs/dir.c
--- a/fs/reiserfs/dir.c Thu Jul 12 13:18:03 2001
+++ b/fs/reiserfs/dir.c Thu Jul 12 13:18:03 2001
@@ -172,7 +172,7 @@
// user space buffer is swapped out. At that time
// entry can move to somewhere else
memcpy (local_buf, d_name, d_reclen);
- if (filldir (dirent, d_name, d_reclen, d_off, d_ino,
+ if (filldir (dirent, local_buf, d_reclen, d_off, d_ino,
DT_UNKNOWN) < 0) {
if (local_buf != small_buf) {
kfree(local_buf) ;
@@ -187,8 +187,6 @@
next_pos = deh_offset (deh) + 1;
if (item_moved (&tmp_ih, &path_to_entry)) {
- reiserfs_warning ("vs-9020: reiserfs_readdir "
- "things are moving under hands.
Researching..\n");
goto research;
}
} /* for */
@@ -202,10 +200,6 @@
delimiting key check is it directory end */
rkey = get_rkey (&path_to_entry, inode->i_sb);
if (! comp_le_keys (rkey, &MIN_KEY)) {
-#ifdef CONFIG_REISERFS_CHECK
- reiserfs_warning ("vs-9025: reiserfs_readdir:"
- "get_rkey failed. Researching..\n");
-#endif
/* set pos_key to key, that is the smallest and greater
that key of the last entry in the item */
set_cpu_key_k_offset (&pos_key, next_pos);
