-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Eric Dumazet wrote: > On Wednesday 12 July 2006 18:42, Jeff Mahoney wrote: >> On systems with block devices containing slashes (virtual dasd, cciss, >> etc), reiserfs will fail to initialize /proc/fs/reiserfs/<dev> due to >> it being interpreted as a subdirectory. The generic block device code >> changes the / to ! for use in the sysfs tree. This patch uses that >> convention. >> >> Tested by making dm devices use dm/<number> rather than dm-<number> > > Your patch handles at most one slash. But the description mentions 'slashes' > (ie several slashes) > >> + if (s) >> + *s = '!'; > > Maybe you need a loop
I'd prefer to correct the grammar rather than the patch. This patch simply duplicates the logic in make_block_name(). - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFEtStALPWxlyuTD7IRAgl0AJ9Q25r0SIZpIZrX/m6ld69OLwvoxQCfdRj/ XIT1LYuQThoypHAx7ud96h8= =0ZdG -----END PGP SIGNATURE-----
