So the Plan 9 and Unix way would be to let the driver parse the number part of the name after the last slash. What I don't understand is why reiserfs is getting involved here, rather than recognizing the driver as an extension of the namespace, seeing the driver as a mountpoint, and just passing number to the driver. There must be something I don't grasp here, can you help me?
Hans Jeff Mahoney wrote: > Bodo Eggert wrote: > > >Eric Dumazet <[EMAIL PROTECTED]> wrote: > > >>On Wednesday 12 July 2006 18:42, Jeff Mahoney wrote: > > >>> On systems with block devices containing slashes (virtual dasd, cciss, > >>> etc), reiserfs will fail to initialize /proc/fs/reiserfs/<dev> due to > >>> it being interpreted as a subdirectory. The generic block device code > >>> changes the / to ! for use in the sysfs tree. This patch uses that > >>> convention. > >>> > >>> Tested by making dm devices use dm/<number> rather than dm-<number> > >> > >>Your patch handles at most one slash. But the description mentions > 'slashes' > >>(ie several slashes) > > >Besides that, there is no reason to prevent the user from using many > slashes. > >OTOH, I'd prefer propper quoting, but having each driver do this would be > >insane. > > > The strings aren't user-supplied, they're kernel-internal names of block > devices, supplied by the driver. At present there is no possibility of > more than one slash in the name, and I doubt we'll see any new devices > with one slash in them, never mind more than one. > > -Jeff > > -- > Jeff Mahoney > SUSE Labs
