> On 2010-10-21 10:21:10, Benjamin Poulain wrote: > > I suggest to put the changes QLatin1String -> QL1S in a separate patch to > > keep the changes simple.
They are in my branch. I pushed here a "sommative" patch. I'm yet at a suboptimal level on using reviewboard.. :( > On 2010-10-21 10:21:10, Benjamin Poulain wrote: > > src/webtab.cpp, lines 87-89 > > <http://git.reviewboard.kde.org/r/100093/diff/1/?file=1943#file1943line87> > > > > Those comments seem out of sync with the code with the changes. They > > should probably be removed. It needs check, yes. It's probably time to. > On 2010-10-21 10:21:10, Benjamin Poulain wrote: > > src/webtab.cpp, lines 92-95 > > <http://git.reviewboard.kde.org/r/100093/diff/1/?file=1943#file1943line92> > > > > I am not following there. Why is page()->loadingUrl() != view()->url() > > if it is a isOnRekonqPage()? because a so called "rekonq pages" are the ones we create with setHtml(), eg the "about:something" links. In those cases, view()->url() returns just "about:blank". > On 2010-10-21 10:21:10, Benjamin Poulain wrote: > > src/webtab.cpp, lines 97-120 > > <http://git.reviewboard.kde.org/r/100093/diff/1/?file=1943#file1943line97> > > > > I would remove the code entirely instead of leaving it here but > > commented. I was sure to have removed then, I'll fix it in a while... - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100093/#review164 ----------------------------------------------------------- On 2010-10-20 16:46:04, Andrea Diamantini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100093/ > ----------------------------------------------------------- > > (Updated 2010-10-20 16:46:04) > > > Review request for rekonq. > > > Summary > ------- > > Fix icons handling for rekonq pages. The so called "rekonq pages" are the > ones rekonq creates itself instead of letting WebKit retrieve them. This > commit aims to fix them (_isOnRekonqPage variable in WebPage) and let icons > work. > > > Diffs > ----- > > src/mainview.cpp 4ccbe93 > src/mainwindow.cpp 4d3dfc9 > src/newtabpage.cpp f5c9c18 > src/protocolhandler.cpp 16af1f3 > src/webpage.h b6e0c53 > src/webpage.cpp 61c6a32 > src/webtab.cpp 2289726 > > Diff: http://git.reviewboard.kde.org/r/100093/diff > > > Testing > ------- > > it works with all the "about" urls > > > Thanks, > > Andrea > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
