----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100093/#review172 -----------------------------------------------------------
Ship it! Looks good to me :) - Benjamin On 2010-10-21 16:19:35, Andrea Diamantini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100093/ > ----------------------------------------------------------- > > (Updated 2010-10-21 16:19:35) > > > Review request for rekonq. > > > Summary > ------- > > Fix icons handling for rekonq pages. The so called "rekonq pages" are the > ones rekonq creates itself instead of letting WebKit retrieve them. This > commit aims to fix them (_isOnRekonqPage variable in WebPage) and let icons > work. > > > Diffs > ----- > > src/mainview.cpp 4ccbe93 > src/mainwindow.cpp 4d3dfc9 > src/newtabpage.cpp f5c9c18 > src/protocolhandler.cpp 16af1f3 > src/webpage.h b6e0c53 > src/webpage.cpp 61c6a32 > src/webtab.cpp 2289726 > > Diff: http://git.reviewboard.kde.org/r/100093/diff > > > Testing > ------- > > it works with all the "about" urls > > > Thanks, > > Andrea > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
