> On 2010-11-16 23:50:52, Pierre Rossi wrote: > > I have to admit, that's way more readable. :) > > I'll test that tomorrow for stuff like "foo" with an url or title in > > "foofoofoo", but other than that, I think the tests cover all the other > > crappy cases I can think of (or Andrea could think of). ;) > > > > We probably still need a Qt::escape at some point, mostly for page titles > > that have stupid characters like '<' and '>', > > twiki(http://twiki.org/cgi-bin/view/TWiki/WhatIsTWiki) is good at that ! > > But I agree ideally the urls have no reason to be escaped. I guess we could > > refine that in another commit
Huh, just built with the patch for testing, and the fact that typing a dot highlights everything totally puts me off ! I have to agree with Benjamin, use of regexps here is going to be trouble. The Qt::escape() could still probably go away for urls but that'll take a bit of refactoring to distinguish url listitem and title listitem... - Pierre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100154/#review347 ----------------------------------------------------------- On 2010-11-16 19:17:39, Jon Ander Peñalba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100154/ > ----------------------------------------------------------- > > (Updated 2010-11-16 19:17:39) > > > Review request for rekonq. > > > Summary > ------- > > I've simplified text highlighting. I think the behaviour hasn't changed, but > a second opinion is welcome :) > > I've removed the Qt::escape (and updated the test accordingly) because I find > it useless, but if it needs to be there for any reason there's no problem in > putting it back. > > > Diffs > ----- > > src/tests/listitem_test.cpp fc0b62e > src/urlbar/listitem.cpp a0462e7 > > Diff: http://git.reviewboard.kde.org/r/100154/diff > > > Testing > ------- > > The 'listitem_test' test passes. > > > Thanks, > > Jon Ander > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
