----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100154/#review363 -----------------------------------------------------------
uhm... I'll probably let you guys fight with the hell of the regexptofindthetexttohighlight :D Good luck! - Andrea On 2010-11-16 19:17:39, Jon Ander Peñalba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100154/ > ----------------------------------------------------------- > > (Updated 2010-11-16 19:17:39) > > > Review request for rekonq. > > > Summary > ------- > > I've simplified text highlighting. I think the behaviour hasn't changed, but > a second opinion is welcome :) > > I've removed the Qt::escape (and updated the test accordingly) because I find > it useless, but if it needs to be there for any reason there's no problem in > putting it back. > > > Diffs > ----- > > src/tests/listitem_test.cpp fc0b62e > src/urlbar/listitem.cpp a0462e7 > > Diff: http://git.reviewboard.kde.org/r/100154/diff > > > Testing > ------- > > The 'listitem_test' test passes. > > > Thanks, > > Jon Ander > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
