----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100230/#review601 -----------------------------------------------------------
It looks good to me otherwise. You could have kept one (or two) blinks with a property animation and the BlinkEffect (defined in the notification bar, would need to be taken out), but that can as well go in another commit, I think this is nice already, we might need to test it a bit and see if there are any usability problems (maybe we'll need to test the color and make it darker if the contrast is bad with the tab background). src/mainview.cpp <http://git.reviewboard.kde.org/r/100230/#comment438> still a style issue here, delete this line. src/tabbar.h <http://git.reviewboard.kde.org/r/100230/#comment439> no need for this blank line ? src/tabbar.cpp <http://git.reviewboard.kde.org/r/100230/#comment440> and this one... src/tabbar.cpp <http://git.reviewboard.kde.org/r/100230/#comment441> and this one :D - Pierre On 2010-12-21 12:24:20, Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100230/ > ----------------------------------------------------------- > > (Updated 2010-12-21 12:24:20) > > > Review request for rekonq. > > > Summary > ------- > > This patch highlights inactive tabs if their title has changed, so people get > aware of changes in the tabs (for instance a new message in a chat window). > I did the one with blinking too, but i think felix is right it is distracting. > > I don't have a kde git account, so please merge it if you like it. > > > Diffs > ----- > > src/mainview.cpp 850101e > src/tabbar.h acd8e2f > src/tabbar.cpp 286d7d4 > > Diff: http://git.reviewboard.kde.org/r/100230/diff > > > Testing > ------- > > compiles and works > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
