----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100230/#review666 -----------------------------------------------------------
It seems pretty good apart from the graphicseffect's class name and lack of genericity (could be refactored in the future). I don't have much time for a more detailed review before next week, but if someone's nice enough to test it and say they like it, I think it could safely be integrated in master at least. src/tabhighlighteffect.h <http://git.reviewboard.kde.org/r/100230/#comment484> Class name should start with a capital letter, i.e. TabHighlightEffect - Pierre On 2010-12-29 23:16:20, Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100230/ > ----------------------------------------------------------- > > (Updated 2010-12-29 23:16:20) > > > Review request for rekonq. > > > Summary > ------- > > This patch highlights inactive tabs if their title has changed, so people get > aware of changes in the tabs (for instance a new message in a chat window). > > I don't have a kde git account, so please merge it if you like it. > > > Diffs > ----- > > src/CMakeLists.txt 6cf2651 > src/mainview.cpp 850101e > src/tabbar.h acd8e2f > src/tabbar.cpp 286d7d4 > src/tabhighlighteffect.h PRE-CREATION > src/tabhighlighteffect.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/100230/diff > > > Testing > ------- > > compiles and works > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
