----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100236/#review632 -----------------------------------------------------------
It seems working quite well in my first test. There are strange code changes that need discussion. src/urlbar/urlresolver.cpp <http://git.reviewboard.kde.org/r/100236/#comment460> I don't understand the API change here. Why did you remove the string check here? - Andrea On 2010-12-23 16:15:20, Lionel Chauvin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100236/ > ----------------------------------------------------------- > > (Updated 2010-12-23 16:15:20) > > > Review request for rekonq. > > > Summary > ------- > > update the completion list when the user switch search engine > > > Diffs > ----- > > src/opensearch/opensearchmanager.h df8e536 > src/opensearch/opensearchmanager.cpp 4ee1de3 > src/opensearch/searchengine.cpp 92b3293 > src/urlbar/completionwidget.h 6545b11 > src/urlbar/completionwidget.cpp 087a10a > src/urlbar/listitem.h 0d66a12 > src/urlbar/listitem.cpp d82613f > src/urlbar/urlresolver.h e6ca770 > src/urlbar/urlresolver.cpp 864eca0 > > Diff: http://git.reviewboard.kde.org/r/100236/diff > > > Testing > ------- > > > Thanks, > > Lionel > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
