> On 2010-12-27 22:04:14, Andrea Diamantini wrote: > > src/urlbar/completionwidget.cpp, line 71 > > <http://git.reviewboard.kde.org/r/100236/diff/1/?file=5585#file5585line71> > > > > Please, use Q_FOREACH instead
ok > On 2010-12-27 22:04:14, Andrea Diamantini wrote: > > src/urlbar/listitem.cpp, line 443 > > <http://git.reviewboard.kde.org/r/100236/diff/1/?file=5587#file5587line443> > > > > Is this really necessary? Comments, please. You are right, the updateList signal seems to be emited twice. I will test to confirm that. > On 2010-12-27 22:04:14, Andrea Diamantini wrote: > > src/urlbar/listitem.cpp, line 571 > > <http://git.reviewboard.kde.org/r/100236/diff/1/?file=5587#file5587line571> > > > > Not sure I understood what happened with the extractQuery function.. :) the goal is to underline "a" in the text instead of "wp:a" - Lionel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100236/#review633 ----------------------------------------------------------- On 2010-12-23 16:15:20, Lionel Chauvin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100236/ > ----------------------------------------------------------- > > (Updated 2010-12-23 16:15:20) > > > Review request for rekonq. > > > Summary > ------- > > update the completion list when the user switch search engine > > > Diffs > ----- > > src/opensearch/opensearchmanager.h df8e536 > src/opensearch/opensearchmanager.cpp 4ee1de3 > src/opensearch/searchengine.cpp 92b3293 > src/urlbar/completionwidget.h 6545b11 > src/urlbar/completionwidget.cpp 087a10a > src/urlbar/listitem.h 0d66a12 > src/urlbar/listitem.cpp d82613f > src/urlbar/urlresolver.h e6ca770 > src/urlbar/urlresolver.cpp 864eca0 > > Diff: http://git.reviewboard.kde.org/r/100236/diff > > > Testing > ------- > > > Thanks, > > Lionel > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
