> On Jan. 11, 2011, 5:10 p.m., Andrea Diamantini wrote: > > I don't think this really solves the situation. You should probably limit > > the "recentlyClosedTabs" list, instead. > > Furkan Üzümcü wrote: > Isn't it used for the closed tabs section on New Tab Page? > If so people might want to get more closed tabs from there. > > Andrea Diamantini wrote: > Yes, it is. > But I think we'll have there the same performance problem you experience > in the context menu. > > Panagiotis Papadopoulos wrote: > actually as far as I can tell there is a big difference between the > context menu and the new tab page with the closed tabs: > > The context menu is there to quickly access the last closed tabs, because > you might’ve closed one or two tabs accidentaly, because your middle mouse > button is kinda broken (true story :-D). > > The problem is, that if that context menu has *a lot* of entries, > displaying the context menu can take *forever*, which defeats the purpose of > the menu. > Also sometimes you accidentaly hove your cursor over that entry and then > you need to wait until the context menu is displayed. > > The new tab page does not have these problems, at least I did not > experience them. Also, you cannot accidentaly click on the closed tab page, > and even if you do, it won’t freeze the browser^^
Sure it does not? The code loading it is quite the same, with the aggravating of loading ALL the thumbnails from the network i.e. connecting again to quite a lot of sites at the same time to grab the preview. I strongely suggest to limit this to something no more than 10. I think 8 should be good. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100315/#review836 ----------------------------------------------------------- On Jan. 7, 2011, 8:29 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100315/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2011, 8:29 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > After a lon rekonq session, you often have closed *a lot* of tabs. If you then > accidentaly closed a tab and you want to open it up, rekonq will freeze, while > the Closed Tabs context menu is loading. This is due to the many entries in > that menu. > Limiting the menu to 10 entries would make the situation better. > This also probably would solve the memory leak, that probably is caused by the > context menu. > > If I use rekonq for a long time, and then close a lot of tabs, the RAM usage > of > rekonq can go as high as 1.5 GB (yes, Gigabyte ;-)) > > https://bugs.kde.org/show_bug.cgi?id=240356 > > > Diffs > ----- > > src/tabbar.cpp 286d7d4 > > Diff: http://git.reviewboard.kde.org/r/100315/diff > > > Testing > ------- > > * Tested and works! > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
