> On Jan. 18, 2011, 8:51 p.m., Lionel Chauvin wrote: > > I think you should split this patch in 3 patches. One per feature (1 for > > the bookmarkwidget, 2 for the previewselectorbar).
I reverted the Bookmark Widget patch. and I don't think that is necessary. The patch is not too big. - Furkan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100286/#review986 ----------------------------------------------------------- On Jan. 18, 2011, 8:12 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100286/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2011, 8:12 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Added support for entering link directly into the Favorites section in the > New Tab . > Preview selector bar shows up as you click on Add Favorites button. > > > Diffs > ----- > > src/newtabpage.cpp 7dcc958 > src/previewselectorbar.h 9684a01 > src/previewselectorbar.cpp c8ab5b0 > src/websnap.cpp 54cf105 > > Diff: http://git.reviewboard.kde.org/r/100286/diff > > > Testing > ------- > > * Tested and works! > > > Screenshots > ----------- > > Adding Favorites > http://git.reviewboard.kde.org/r/100286/s/52/ > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
