----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100286/#review980 -----------------------------------------------------------
>From a Quick review a few issues that i found, apart from a usability point of >view, id like to see the QCheckBox be converted to a QPushButton src/previewselectorbar.h <http://git.reviewboard.kde.org/r/100286/#comment796> Can be forward declared imo src/previewselectorbar.cpp <http://git.reviewboard.kde.org/r/100286/#comment797> Remove the code if you dont really need it ;) src/urlbar/bookmarkwidget.h <http://git.reviewboard.kde.org/r/100286/#comment798> Its best to define this on bookmarkwidget.cpp, would like a second opinion on this tho - Rohan On Jan. 18, 2011, 3:31 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100286/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2011, 3:31 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Added support for entering link directly into the Favorites section in the > New Tab . > > > Diffs > ----- > > src/newtabpage.cpp 7dcc958 > src/previewselectorbar.h 9684a01 > src/previewselectorbar.cpp c8ab5b0 > src/urlbar/bookmarkwidget.h e07dac2 > src/urlbar/bookmarkwidget.cpp 4569bc2 > src/websnap.cpp 54cf105 > > Diff: http://git.reviewboard.kde.org/r/100286/diff > > > Testing > ------- > > * Tested and works! > > > Screenshots > ----------- > > Add to Favorites > http://git.reviewboard.kde.org/r/100286/s/50/ > Remove from Favorites > http://git.reviewboard.kde.org/r/100286/s/51/ > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
