> On Jan. 17, 2011, 4:25 p.m., Andrea Diamantini wrote: > > I like this, there is just one small thing to fix before merge. Or did you > > discuss something different in ml? I couldn't follow it.. > > Furkan Üzümcü wrote: > They talked about adding a button to the url bar like the add bookmark > button. But nobody said anything about it in ml. I'm updating the patch. > > Lionel Chauvin wrote: > I thought about reintroduce an "add bookmark" popup that allow to choose > the bookmark folder and that propose to add this bookmark in the favorite too > (with a checkbox). > > Andrea Diamantini wrote: > I like that, Lionel. But I don't think it lets this be "unuseful". I'm > for merging if you and ... (who implemented this?).. have no objections. Do > you? > > Lionel Chauvin wrote: > With this patch, what the user will do ? > He will open a tab, > visit the website he want add as preview, > click on the new tab button, > add a preview, > click on the preview, > go to the previous tab, > copy the url, > go the the new tab page, > paste the url. > validate. > > I think the feature of this patch were not needed if the > previewselectorbar were global to all tabs like it was when Mathieu Gicquel > introduced it. > > With this workflow the user will: > open a tab, > visit the website he want add as preview, > click on the new tab button, > add a preview, > click on the preview, > go to the previous tab, > validate. > > > > Furkan Üzümcü wrote: > You got a point, > but what if user wants to add a page he/she hasn't opened to favorites? > > Lionel Chauvin wrote: > if the page is not opened, I assume the user has the url in the clipboard. > He just open a new tab page, > click on add preview > click on the preview > paste the url in the urlbar > press enter > validate > > > > > Lionel Chauvin wrote: > When I say "add preview" I mean "add favorite" in the favorite page. > > I just think about the workflow: > why "add favorite" add a empty preview ? why it does not only open the > previewselectorbar ? It would remove one click. > > Andrea Diamantini wrote: > It seems we are considering some different use cases: > 1) user is visiting a page and he'd like adding it as favorite. We > actually have no one-click solution for this. The "love" button could be > perfect here. Or the revisited "add bookmark" popup. > 2) user is visiting his about:favorites page and likes to > set/order/cleanup it. Here current solution just works. Furkan's patch adds > an extra case to let life easier when user just knows his favorites urls or > have it/them in the clipboard. > > The "add favorite" button has to open the previewselectorbar. Lionel is > right here. > > Lionel Chauvin wrote: > 2) I don't see why it let life easier. > Because the user doesn't need to press enter ? > Because the user doesn't wait loading ? > Can't these problems be fixed in an other way ? > > I still think there is a problem if the user needs to enter an url at > another place than the urlbar. > > Furkan Üzümcü wrote: > Your answer is "Yes" for those questions. > For adding a open page to favorites we can add a checkbox to the add > bookmark pop up to add it also to favorites. > How about that?
Just to remember that we no more have an "add bookmark" popup :) - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100286/#review957 ----------------------------------------------------------- On Jan. 18, 2011, 8:12 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100286/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2011, 8:12 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Added support for entering link directly into the Favorites section in the > New Tab . > Preview selector bar shows up as you click on Add Favorites button. > > > Diffs > ----- > > src/newtabpage.cpp 7dcc958 > src/previewselectorbar.h 9684a01 > src/previewselectorbar.cpp c8ab5b0 > src/websnap.cpp 54cf105 > > Diff: http://git.reviewboard.kde.org/r/100286/diff > > > Testing > ------- > > * Tested and works! > > > Screenshots > ----------- > > Adding Favorites > http://git.reviewboard.kde.org/r/100286/s/52/ > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
