-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100683/
-----------------------------------------------------------
(Updated Feb. 21, 2011, 9:40 p.m.)
Review request for rekonq and Benjamin Poulain.
Changes
-------
This new patch implements a null rule to match all unimplemented filters.
Just for the records, we have this way implemented 3 different kind of rules:
- Text: 1753 filters matched,
- Fallback: 1305 filters,
- Null: 1154 filters.
So, this implementation saves sizeof(QString)*1154 bytes. It is anyway a bit
more heavy on startup, having the extra null check added. Not so easy to
measure how much heavier.. ;)
Summary
-------
AdBlock clean up.
With this patch we explicitely allow any option that has not been (yet) fully
implemented.
This addresses bugs 248045, 253329 and 265909.
/show_bug.cgi?id=248045
/show_bug.cgi?id=253329
/show_bug.cgi?id=265909
Diffs (updated)
-----
src/CMakeLists.txt e0f75a0
src/adblock/adblockmanager.cpp fb36ef0
src/adblock/adblockrule.h 8111005
src/adblock/adblockrule.cpp 1cb6773
src/adblock/adblockrulenullimpl.h PRE-CREATION
src/adblock/adblockrulenullimpl.cpp PRE-CREATION
src/adblock/adblockruletextmatchimpl.cpp 7296d83
Diff: http://git.reviewboard.kde.org/r/100683/diff
Testing
-------
Thanks,
Andrea
_______________________________________________
rekonq mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/rekonq
