----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101018/#review2415 -----------------------------------------------------------
src/urlbar/urlbar.cpp <http://git.reviewboard.kde.org/r/101018/#comment2073> Why that? Why are you breaking another feature to enable yours? Did you check if your changes are ok against text dragging? src/urlbar/urlbar.cpp <http://git.reviewboard.kde.org/r/101018/#comment2069> What is the need for such check? src/urlbar/urlbar.cpp <http://git.reviewboard.kde.org/r/101018/#comment2070> We have an rApp pointer now. Please, use it. src/urlbar/urlbar.cpp <http://git.reviewboard.kde.org/r/101018/#comment2071> I'm not sure to understand the difference between the stringToDrag and the selectedText() output. Can the last be used instead? src/urlbar/urlbar.cpp <http://git.reviewboard.kde.org/r/101018/#comment2072> double ;; - Andrea On April 4, 2011, 4:18 a.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101018/ > ----------------------------------------------------------- > > (Updated April 4, 2011, 4:18 a.m.) > > > Review request for rekonq. > > > Summary > ------- > > Drag and rop the url from the urlbar to add it as a bookmark. > > > Diffs > ----- > > src/bookmarks/bookmarkstoolbar.cpp 8da30c6 > src/urlbar/urlbar.h 9ed89da > src/urlbar/urlbar.cpp 4d53e17 > > Diff: http://git.reviewboard.kde.org/r/101018/diff > > > Testing > ------- > > Compiles and works. > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
