----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101018/#review2484 -----------------------------------------------------------
I pushed in master a different patch, based on Furkan's work. This is basically based on two considerations: first, the "need" to not modify a lot actual code in the urlbar. Second, the problem of showing "as urls" (showing their icon) TEXT mimeData: not a good choice, IMHO. Actual code is cleaner and works with every drop inside the bk toolbar (In case of text, checking if the derivated url is valid) - Andrea On April 6, 2011, 4:36 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101018/ > ----------------------------------------------------------- > > (Updated April 6, 2011, 4:36 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Drag and rop the url from the urlbar to add it as a bookmark. > > > Diffs > ----- > > src/urlbar/urlbar.cpp 0a6783a > src/bookmarks/bookmarkstoolbar.cpp 8da30c6 > src/urlbar/urlbar.h 9ed89da > > Diff: http://git.reviewboard.kde.org/r/101018/diff > > > Testing > ------- > > Compiles and works. > > > Thanks, > > Furkan > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
