> On April 8, 2011, 6:47 p.m., Rohan Garg wrote:
> > src/tabbar.cpp, line 206
> > <http://git.reviewboard.kde.org/r/101062/diff/1/?file=14039#file14039line206>
> >
> > I'm not entirely sure if others would agree or not, but the formatting
> > should be something like :
> > if(foo){
> > bar
> > }
Now that's a pretty sensitive subject, with the coding style adopted for Qt and
KDElibs, things would actually be:
if (foo) {
++bar;
somethingElse();
}
but Rekonq has a slightly different coding style (I'm not a huge fan, but we
need to follow conventions if we don't want things to get messy):
if (foo)
{
++bar;
somethingElse();
}
Long story short: there's a space missing before the opening bracket.
- Pierre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101062/#review2502
-----------------------------------------------------------
On April 8, 2011, 7:40 p.m., Tirtha Chatterjee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101062/
> -----------------------------------------------------------
>
> (Updated April 8, 2011, 7:40 p.m.)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> Right now, the size of a tab preview keeps decreasing as tab size decreases.
> This patch fixes the size of preview to the default base width of a tab (the
> max width of the tab) which a tab has at the beginning.
>
>
> Diffs
> -----
>
> src/tabbar.cpp 1ab357f
>
> Diff: http://git.reviewboard.kde.org/r/101062/diff
>
>
> Testing
> -------
>
> Tested. Working properly.
>
>
> Thanks,
>
> Tirtha
>
>
_______________________________________________
rekonq mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/rekonq
