> On April 8, 2011, 10:36 p.m., Pierre Rossi wrote: > > src/tabbar.cpp, line 210 > > <http://git.reviewboard.kde.org/r/101062/diff/3/?file=14052#file14052line210> > > > > same here. > > Andrea Diamantini wrote: > Wrong. We need them as it is our convention using braces even for one > line statements. To know more about, read > http://techbase.kde.org/Policies/Kdelibs_Coding_Style and > https://projects.kde.org/projects/extragear/network/rekonq/repository/revisions/master/entry/scripts/codingstyle.sh.
Huh, my bad, I was fairly certain KDE and Qt coding style converged on that point. Well then it's still missing a space between the if and the opening brace, and I suppose the curly brace should be on a new line then to follow the specificity of Rekonq coding style. - Pierre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101062/#review2505 ----------------------------------------------------------- On April 8, 2011, 7:40 p.m., Tirtha Chatterjee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101062/ > ----------------------------------------------------------- > > (Updated April 8, 2011, 7:40 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Right now, the size of a tab preview keeps decreasing as tab size decreases. > This patch fixes the size of preview to the default base width of a tab (the > max width of the tab) which a tab has at the beginning. > > > Diffs > ----- > > src/tabbar.cpp 1ab357f > > Diff: http://git.reviewboard.kde.org/r/101062/diff > > > Testing > ------- > > Tested. Working properly. > > > Thanks, > > Tirtha > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
