----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101848/#review4410 -----------------------------------------------------------
the previews look quite nice. i've just pointed out a few minor issues, but i'm not sure if i'd do it this way. have you considered leaving the presentation stuff to the paintevent only? i don't think you need all those widgets src/tabpreviewpopup.h <http://git.reviewboard.kde.org/r/101848/#comment3711> trailing space, you've made several of them src/tabpreviewpopup.h <http://git.reviewboard.kde.org/r/101848/#comment3710> use "m_" prefix here to show that they are member variables src/tabpreviewpopup.h <http://git.reviewboard.kde.org/r/101848/#comment3712> i'd add these static variables to tabpreviewpopup.cpp as const global variables src/tabpreviewpopup.cpp <http://git.reviewboard.kde.org/r/101848/#comment3713> i would initialize them in the class's initialization list src/tabpreviewpopup.cpp <http://git.reviewboard.kde.org/r/101848/#comment3714> wrong indent - Johannes On July 4, 2011, 3:06 p.m., Vyacheslav Blinov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101848/ > ----------------------------------------------------------- > > (Updated July 4, 2011, 3:06 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Improvements: > > * title of the page is removed since it is visible on a tab. > * widget now has a smooth 3d look'n'feel with Oxygen thanks to raisen frame > * widget has rouned corners in all the styles > * url of the page is elided > * with compositing tab previews will be shown semitransparent with 25% alpha > by default, witch can be setted to be optional later > * code of tab preview is now separated from tab bar so it is more explicit > > > Diffs > ----- > > src/CMakeLists.txt db9506a > src/tabbar.h c1b0ba5 > src/tabbar.cpp dee49ea > src/tabpreviewpopup.h PRE-CREATION > src/tabpreviewpopup.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101848/diff > > > Testing > ------- > > Tested with different styles: it still looks ok, without compositing > transparency didn't works > > > Screenshots > ----------- > > sample of tab preview > http://git.reviewboard.kde.org/r/101848/s/193/ > > > Thanks, > > Vyacheslav > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
