----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101848/#review4611 -----------------------------------------------------------
this patch is already very good, i'm just an ass and pointed out some ultra-minor issues i've found :D src/tabpreviewpopup.h <http://git.reviewboard.kde.org/r/101848/#comment4029> forward declare this one. src/tabpreviewpopup.h <http://git.reviewboard.kde.org/r/101848/#comment4030> i'd do this one and setThumbnail with a const reference parameter. have a look here: http://pages.cs.wisc.edu/~hasti/cs368/CppTutorial/NOTES/PARAMS.html src/tabpreviewpopup.cpp <http://git.reviewboard.kde.org/r/101848/#comment4031> if you don't have one, don't list it ;) src/tabpreviewpopup.cpp <http://git.reviewboard.kde.org/r/101848/#comment4032> style: in rekonq we don't have spacec between braces. (but that's not really important to me :D ) src/tabpreviewpopup.cpp <http://git.reviewboard.kde.org/r/101848/#comment4033> style: in rekonq we use to have a space between "if" and the condition. you could also just write: if (webtab) setWebTab(webtab); src/tabpreviewpopup.cpp <http://git.reviewboard.kde.org/r/101848/#comment4034> same here with spaces between braces - Johannes On July 11, 2011, 10:13 a.m., Vyacheslav Blinov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101848/ > ----------------------------------------------------------- > > (Updated July 11, 2011, 10:13 a.m.) > > > Review request for rekonq. > > > Summary > ------- > > Improvements: > > * title of the page is removed since it is visible on a tab. > * widget now has a smooth 3d look'n'feel with Oxygen thanks to raisen frame > * widget has rouned corners in all the styles > * url of the page is elided > * with compositing tab previews will be shown semitransparent with 25% alpha > by default, witch can be setted to be optional later > * code of tab preview is now separated from tab bar so it is more explicit > > > Diffs > ----- > > src/CMakeLists.txt db9506a > src/tabbar.h c1b0ba5 > src/tabbar.cpp dee49ea > src/tabpreviewpopup.h PRE-CREATION > src/tabpreviewpopup.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101848/diff > > > Testing > ------- > > Tested with different styles: it still looks ok, without compositing > transparency didn't works > > > Screenshots > ----------- > > sample of tab preview > http://git.reviewboard.kde.org/r/101848/s/193/ > > > Thanks, > > Vyacheslav > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
