> On July 16, 2011, 9:10 a.m., Pierre Rossi wrote: > > src/urlbar/urlbar.cpp, line 521 > > <http://git.reviewboard.kde.org/r/101945/diff/1/?file=27021#file27021line521> > > > > I know this is not necessarily related, but how about we put asserts in > > places like these ?
sure ;) - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101945/#review4724 ----------------------------------------------------------- On July 13, 2011, 4:37 p.m., Andrea Diamantini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101945/ > ----------------------------------------------------------- > > (Updated July 13, 2011, 4:37 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Provide a "click" mechanism to manage favorites > > With this commit, you can add a favorite by clicking 2 times in the bookmark > icon. > If an URL is a favorite, the favorite icon appears and then you can manage it > from there... > > Pushed on remote branch: AddFavoriteWithAClick > > > Diffs > ----- > > src/CMakeLists.txt f623adf > src/urlbar/favoritewidget.h PRE-CREATION > src/urlbar/favoritewidget.cpp PRE-CREATION > src/urlbar/urlbar.h 9ed89da > src/urlbar/urlbar.cpp 078dc6a > > Diff: http://git.reviewboard.kde.org/r/101945/diff > > > Testing > ------- > > > Thanks, > > Andrea > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
