----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101945/#review4879 -----------------------------------------------------------
Looks like a lot of changes don't belong there... src/urlbar/favoritewidget.cpp <http://git.reviewboard.kde.org/r/101945/#comment4252> missing the space between "if" and '(' Actually I noticed You have a *lot* of changes like these, way more than reasonable for just a patch update. Could it be your IDE trying to be a smart ass or something ? src/urlbar/urlbar.h <http://git.reviewboard.kde.org/r/101945/#comment4253> that's still something I don't get... Since we're not a library, we could be using the "good looking" keywords, why use the not so nice Q_* macros instead ? src/urlbar/urlbar.h <http://git.reviewboard.kde.org/r/101945/#comment4254> better function naming ? bookmarkContextMenu maybe. - Pierre On July 18, 2011, 8:12 p.m., Andrea Diamantini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101945/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 8:12 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > Provide a "click" mechanism to manage favorites > > With this commit, you can add a favorite by clicking 2 times in the bookmark > icon. > If an URL is a favorite, the favorite icon appears and then you can manage it > from there... > > Pushed on remote branch: AddFavoriteWithAClick > > > Diffs > ----- > > src/CMakeLists.txt fd94616 > src/urlbar/favoritewidget.h PRE-CREATION > src/urlbar/favoritewidget.cpp PRE-CREATION > src/urlbar/urlbar.h 9ed89da > src/urlbar/urlbar.cpp ea60f47 > > Diff: http://git.reviewboard.kde.org/r/101945/diff > > > Testing > ------- > > > Thanks, > > Andrea > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
