----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102331/#review5724 -----------------------------------------------------------
src/urlbar/urlbar.cpp <http://git.reviewboard.kde.org/r/102331/#comment5084> you probably want to add this line to avoid leaking: menu->setAttribute(Qt::WA_DeleteOnClose) src/urlbar/urlbar.cpp <http://git.reviewboard.kde.org/r/102331/#comment5083> maybe menu->popup would be enough src/urlbar/urlbar.cpp <http://git.reviewboard.kde.org/r/102331/#comment5085> maybe a guard here in case people call paste and Go from elsewhere... Or the whole clipboard logic could be moved here altogether, that's probably simpler. - Pierre On Aug. 15, 2011, 7:30 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102331/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2011, 7:30 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > "paste & go" action in urlbar's context menu > this feature is also available in firefox > > > Diffs > ----- > > src/urlbar/urlbar.h 58e9b5f > src/urlbar/urlbar.cpp 17ba4bb > > Diff: http://git.reviewboard.kde.org/r/102331/diff > > > Testing > ------- > > compiles and works. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/102331/s/228/ > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
