> On Aug. 18, 2011, 11:32 p.m., Andrea Diamantini wrote: > > src/urlbar/urlbar.cpp, line 473 > > <http://git.reviewboard.kde.org/r/102331/diff/3/?file=31981#file31981line473> > > > > uhm... what if standard context menu changes? > > Pierre Rossi wrote: > a new one is created each time. :) > > Andrea Diamantini wrote: > Yes :) > What if it "changes everytime" i.e. a couple of actions are inserted at > start, so that the position after "paste" is no more the 6th. I understand > this is not so probable, just my constant value internal alert :D > > Pierre Rossi wrote: > Wait, what ?!!?? I hadn't seen this 6 in there !!! And I only read your > comment, so I thought you worried about adding the action even when the > clipboard is empty. > Ok, so that one is an obvious blunder, and I missed it :) i'd say > addAction would be enough, maybe with a addSeparator just before that. > > Pierre Rossi wrote: > mhh in order to be in the right location (that makes more sense for the > user), it'd probably be even better to look for the paste action and insert > after it. > > Johannes Tröscher wrote: > this 6 is the paste action. i just wanted to insert the "paste and go" > action after it, but yeah, it's a bit hackish :D
Anyway, if we decide to go for a "custom" context menu, the problem will be fixed anyway. Johannes? - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102331/#review5808 ----------------------------------------------------------- On Aug. 15, 2011, 9:06 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102331/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2011, 9:06 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > "paste & go" action in urlbar's context menu > this feature is also available in firefox > > > Diffs > ----- > > src/urlbar/urlbar.h 58e9b5f > src/urlbar/urlbar.cpp 17ba4bb > > Diff: http://git.reviewboard.kde.org/r/102331/diff > > > Testing > ------- > > compiles and works. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/102331/s/228/ > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
